Avoid conditional module inclusion #760
Closed
+97
−107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires slightly more logic in util_libc, but produces a more typical setup for the crate.
tamird
force-pushed
the
cleanup-modules
branch
from
86327dd to
bd52e38
Compare
Member
|
Personally, I think the proposed approach is slightly more complex and less clear. But it gave me an idea which I would like to try a bit later. |
Member
|
Closing in favor of #763. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires slightly more logic in util_libc, but produces a more
typical setup for the crate.
Extracted from #759.